That's basically it...Except I like to use Purple Onion....And I sometimes throw chopped celery in it... And I always make it CHUNKY....Otherwise it's not really salad-ish, more like musterdy mashed potatoes....
I like chunks and tossed with the mayo. The potatoes sometimes do get mushy. I have found that the best way to prevent mushy is to boil the potatoes whole with the peel. Let them cool and refrigerate before peeling then cut into chunks.
My potato salad is miracle whip, french's mustard, boiled eggs and dill mostly mashed. Never a complaint I once made two turkey pans full for a party and it all disappeared with guests asking if there was more.